Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump semantic release #236

Merged
merged 4 commits into from
Nov 13, 2024
Merged

fix: bump semantic release #236

merged 4 commits into from
Nov 13, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Nov 12, 2024

I have no idea if this will work tbh.

But we are so behind on the semantic release versioning it isn't working with the newer python versioning required for the map parser.

I took this config directly from their migration guide.

@humbertogontijo
Copy link
Owner

I have limited knowledge on GitHub actions and semantic release lib. But we can try it out

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 12, 2024

Can you give me a invite to the pypi repo again - I didn't accept it in time I guess?

I believe we may have to specify a trusted publisher of this github action https://docs.pypi.org/trusted-publishers/

@humbertogontijo
Copy link
Owner

Invite sent

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 13, 2024

Invite sent

Perfect, can you go ahead and approve the pr again? That way once I get the pypi side ready I can just merge

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 13, 2024

@humbertogontijo I should be able to test it now that's its setup just need a approval to be able to merge

@Lash-L Lash-L merged commit cf067d4 into main Nov 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants