Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update mop intensity, fan speed, and dock mappings for the QRevo Master #260

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

rccoleman
Copy link
Contributor

No description provided.

@rccoleman rccoleman changed the title Fix mop intensity and fan speed mappings for the QRevo Master Update mop intensity, fan speed, and dock mappings for the QRevo Master Dec 19, 2024
@rccoleman rccoleman closed this Dec 19, 2024
@rccoleman rccoleman reopened this Dec 20, 2024
@rccoleman rccoleman changed the title Update mop intensity, fan speed, and dock mappings for the QRevo Master fix: Update mop intensity, fan speed, and dock mappings for the QRevo Master Dec 20, 2024
@rccoleman rccoleman changed the title fix: Update mop intensity, fan speed, and dock mappings for the QRevo Master fix: update mop intensity, fan speed, and dock mappings for the QRevo Master Dec 20, 2024
@Lash-L
Copy link
Collaborator

Lash-L commented Dec 20, 2024

Can you run pre commit locally

@rccoleman
Copy link
Contributor Author

I did, and it passes. I'm really confused about what happened there. It's complaining about the imports not being sorted, which was a problem in the last commit (db11c0f), but not on the tip of the branch and containers.py wasn't changed in my PR.

(venv) rcoleman@rcoleman-linux ~/git/python-roborock % pre-commit run --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[WARNING] repo `https://github.com/pre-commit/pre-commit-hooks` uses deprecated stage names (commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/pre-commit/pre-commit-hooks` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Initializing environment for https://github.com/python-poetry/poetry.
[INFO] Initializing environment for https://github.com/codespell-project/codespell.
[INFO] Initializing environment for https://github.com/charliermarsh/ruff-pre-commit.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Initializing environment for https://github.com/pre-commit/mirrors-mypy:types-paho-mqtt.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/python-poetry/poetry.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/codespell-project/codespell.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/charliermarsh/ruff-pre-commit.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/pre-commit/mirrors-mypy.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
debug statements (python)................................................Passed
check builtin type constructor use.......................................Passed
check for case conflicts.................................................Passed
check docstring is first.................................................Passed
check json...............................................................Passed
check toml...............................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
poetry-check.............................................................Passed
codespell................................................................Passed
ruff-format..............................................................Passed
ruff.....................................................................Passed
mypy.....................................................................Passed

@Lash-L
Copy link
Collaborator

Lash-L commented Dec 20, 2024

Looks like the lint problem was actually introduced in the last commit. Just manually make the change in containers.py if you need to to get us passing

@rccoleman
Copy link
Contributor Author

That's the thing - they are sorted on the tip, so there's nothing to push.

@Lash-L
Copy link
Collaborator

Lash-L commented Dec 20, 2024

The issue is present on main as well

https://github.com/humbertogontijo/python-roborock/blob/main/roborock/containers.py

And I don't see any changes for containers.py on this pr, are you sure it's pushed?

@rccoleman
Copy link
Contributor Author

You're right - I kept looking at the MopIntensity imports and not MopMode.

@humbertogontijo humbertogontijo merged commit 77f6d6f into humbertogontijo:main Dec 20, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants