Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configure the printer PHP version to 7.2 by default #1049

Merged
merged 5 commits into from
Jun 16, 2024

Conversation

theofidry
Copy link
Member

@theofidry theofidry commented Jun 16, 2024

See the discussion in nikic/PHP-Parser#1007.

This should fix sebastianbergmann/phpunit#5855 although this may result in more ugly code formatting than desired. For this reason the default printer version is 7.2 rather than 5.3 as it would make the code too otherwise.

@theofidry theofidry enabled auto-merge (squash) June 16, 2024 15:33
auto-merge was automatically disabled June 16, 2024 15:34

Head branch was modified

@theofidry theofidry changed the title fix: Configure the printer PHP version to 5.3 by default fix: Configure the printer PHP version to 7.2 by default Jun 16, 2024
@theofidry theofidry merged commit 41eff3d into humbug:main Jun 16, 2024
126 checks passed
@theofidry theofidry deleted the fix/printer-version branch June 16, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP-Scoper 0.18.12 breaks PHAR for PHPUnit 8.5 on PHP 7.2
1 participant