Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the event ingest buffer via flags and default to 1MB events #127

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Set the event ingest buffer via flags and default to 1MB events #127

merged 1 commit into from
Aug 17, 2023

Conversation

skovmand
Copy link

@skovmand skovmand commented Aug 17, 2023 •
edited
Loading

This PR:

  • allows the user to set a custom ingest buffer size from the command line via the --ingest-buffer-size flag.
  • updates the default buffer size to 1MB to align with the LogScale default max event size.

I think it would be good to check if it conflicts with the --batch-bytes flag.

For the review, please verify that the buffer is created and used the correct way - I am not experienced with Go.

@skovmand skovmand requested a review from a team as a code owner August 17, 2023 06:49
@SaaldjorMike SaaldjorMike merged commit dd0b7a3 into humio:master Aug 17, 2023
@skovmand skovmand deleted the set-ingest-buffer-via-flags branch August 27, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaaldjorMike SaaldjorMike SaaldjorMike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skovmand @SaaldjorMike