-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/database manager #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests performed:
- Cloned and install feature branch and PR6288
- conda env create -f environment_conda.yml
- conda activate streamlit-apps
- streamlit run main.py
- Copied URL to browser
- Created symlink with ln -s /path/to/hummingbot/data data
- Review Strategy Performance now shows fees in USDT for binance spot
- Confirmed fees amount is showing correct amount
Note: for binance perpetual
there's ongoing issue on Strategy Performance tab
with AttributeError: module 'ccxt' has no attribute 'binance_perpetual'
Mentioned that ccxt will be removed in another PR |
This PR is adding a database manager class to improve the communication with the sqlite database.
Also, the logic of the trade fees was included in the strategy data class and in the graphs.
Minor improvements in graph style too.