Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/database manager #15

Merged
merged 10 commits into from
May 11, 2023
Merged

Feat/database manager #15

merged 10 commits into from
May 11, 2023

Conversation

cardosofede
Copy link
Contributor

This PR is adding a database manager class to improve the communication with the sqlite database.
Also, the logic of the trade fees was included in the strategy data class and in the graphs.
Minor improvements in graph style too.

Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but note that I couldn't get past this UX issue:

Screen Shot 2023-05-08 at 7 37 46 PM

Looks like I need to define a config file, but it's grayed out.

@cardosofede
Copy link
Contributor Author

image
@fengtality is possible that you don't have trades available?

@fengtality
Copy link
Contributor

is possible that you don't have trades available?

Yup, that DB has no trades. I suggest handling that case and display a message.

I would also add a note saying that it only works on Binance and Binance Futures currently, since it's tailored to their trading symbol format.

Screen Shot 2023-05-09 at 10 02 52 AM

@fengtality
Copy link
Contributor

Screen Shot 2023-05-09 at 10 13 14 AM

works well on binance_paper_trade

Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests performed:

  • Cloned and install feature branch and PR6288
  • conda env create -f environment_conda.yml
  • conda activate streamlit-apps
  • streamlit run main.py
  • Copied URL to browser
  • Created symlink with ln -s /path/to/hummingbot/data data
  • Review Strategy Performance now shows fees in USDT for binance spot
  • Confirmed fees amount is showing correct amount

Note: for binance perpetual there's ongoing issue on Strategy Performance tab with AttributeError: module 'ccxt' has no attribute 'binance_perpetual'

@nikspz nikspz merged commit 14162c2 into main May 11, 2023
@nikspz
Copy link
Contributor

nikspz commented May 11, 2023

Mentioned that ccxt will be removed in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants