Fix / Kujira / New tendermint changes #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaro-mota-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
0a9c9b8 to
f3ae8a4
Compare
danilo-silva-funttastic
changed the title
alvaro-mota-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
f3ae8a4 to
de29e8d
Compare
danilo-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
de29e8d to
a42c013
Compare
danilo-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
2 times, most recently
from
27ab13e to
bd9c79a
Compare
|
Hi @fengtality, @cardosofede, @rapcmia We've created this PR (and another one for the Client) in order to update and improve our connector due to some feedback we've received from our users also to conform to the new breaking changes on the Kujira blockchain. The summary of the PR explain the changes and they are relatively simple, for this one we need to touch some more files because it was needed to change the Tendermint references in different ones. Disclaimer: unfortunately (as it has happened before), our build is not green but the tests which are failing are not related to us or our code, it's related with ethereum. Please kindly take a look at it when you have time. |
danilo-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
bd9c79a to
074c139
Compare
rapcmia
approved these changes
Nov 2, 2023
danilo-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
074c139 to
87098b6
Compare
darley-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
87098b6 to
524e832
Compare
…ating CLOB validator to accept market orders. commit 0854c33 Author: Danilo Araújo Silva <danilo.silva@funttastic.com> Date: Wed Oct 25 23:38:51 2023 +0300 Adding support market orders. commit 0379f28 Author: Danilo Araújo Silva <danilo.silva@funttastic.com> Date: Wed Oct 25 21:39:00 2023 +0300 Updating yarn.lock. commit f3ae8a4 Author: Álvaro E. F. Mota <alvaro.mota@funttastic.com> Date: Fri Oct 20 18:40:28 2023 -0300 Added two more test to cover exception cases commit da4b091 Author: Álvaro E. F. Mota <alvaro.mota@funttastic.com> Date: Fri Oct 20 17:22:39 2023 -0300 Added some tests that cover some exceptions commit 49ac103 Author: Álvaro E. F. Mota <alvaro.mota@funttastic.com> Date: Tue Oct 17 18:40:02 2023 -0300 Updated the Tendermint version
darley-silva-funttastic
force-pushed
the
fix/kujira/tendermint-changes
branch
from
524e832 to
15d7dc8
Compare
fengtality
approved these changes
Nov 13, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new changes to the Kujira blockchain and the Cosmos library,
we are updating the code changing the references of the Tendermin34Client class in favor or the Tendermint37Client class,
now necessary to keep the connector working properly.
We also used the opportunity to create some more unit tests to increase the test coverage.
Finally we've updated a CLOB core validator to also accept market orders.