Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) remove injective chain and exchange connectors #230

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

fengtality
Copy link
Contributor

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:

  • Removes Injective chain connector
  • Removes Injective and Injective perp clob DEX connectors

Tests performed by the developer:

  • Note that I left the Injective library as a CLOB controller file depends on it. Also, the CLOB tests use Injective, so I have commented them out. I will create a bounty later that lets someone clean this up.

Tips for QA testing:

@fengtality fengtality requested a review from nikspz November 9, 2023 16:20
Copy link
Contributor

@nikspz nikspz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test performed:

  • Cloned and installed fix branch
  • Reviewed no injective_v1 gateway connectors showing in gateway connect, gateway list
  • connected injective_v2
  • checked balance matched with the helix exchange
  • created/started PureMM using injective_v2 successfully
  • Manually built docker image

@nikspz nikspz merged commit ed3b1cb into development Nov 10, 2023
5 checks passed
@nikspz nikspz deleted the fix/remove-injective branch November 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants