Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/ Fix account balance not reflect correctly + Improve websocket connection #249

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

mlguys
Copy link
Contributor

@mlguys mlguys commented Dec 11, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Fixed:

Tests performed by the developer:

Tips for QA testing:

Copy link
Contributor

@rapcmia rapcmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Setup mainnet wallet ok
  • Setup account using XUMM app
  • Run SOLO/XRP observe available balance now updated per refresh cycle
  • Trade data between client history, csv and exchange trade history matched

@rapcmia rapcmia merged commit 343eead into development Dec 14, 2023
4 of 5 checks passed
@rapcmia rapcmia deleted the feat/xrpl-fix-dec-11 branch December 14, 2023 01:55
@rapcmia
Copy link
Contributor

rapcmia commented Dec 14, 2023

Merged to development and part of release version 1.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants