add type="button" to all components using button element (#150)

add default type="button" to all components using button element

.changeset/proud-laws-jump.md

@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+add default type="button" to all components using button element

src/lib/bits/accordion/components/AccordionTrigger.svelte

@@ -20,6 +20,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-keydown={dispatch}

src/lib/bits/alert-dialog/components/AlertDialogAction.svelte

@@ -22,6 +22,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/alert-dialog/components/AlertDialogCancel.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/alert-dialog/components/AlertDialogTrigger.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		on:m-click={dispatch}
 		on:m-keydown={dispatch}
 		{...$$restProps}

src/lib/bits/checkbox/components/Checkbox.svelte

@@ -51,6 +51,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/collapsible/components/CollapsibleTrigger.svelte

@@ -19,7 +19,7 @@
 {#if asChild}
 	<slot {builder} {attrs} />
 {:else}
-	<button use:melt={builder} {...$$restProps} {...attrs} on:m-click={dispatch}>
+	<button use:melt={builder} type="button" {...$$restProps} {...attrs} on:m-click={dispatch}>
 		<slot {builder} {attrs} />
 	</button>
 {/if}

src/lib/bits/dialog/components/DialogClose.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/dialog/components/DialogTrigger.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/dropdown-menu/components/DropdownMenuTrigger.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-keydown={dispatch}

src/lib/bits/menubar/components/MenubarTrigger.svelte

@@ -20,6 +20,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/popover/components/PopoverClose.svelte

@@ -1,11 +1,11 @@
 <script lang="ts">
 	import { melt } from "@melt-ui/svelte";
 	import { getCtx, getAttrs } from "../ctx.js";
-	import type { TriggerEvents, TriggerProps } from "../types.js";
+	import type { CloseProps, CloseEvents } from "../types.js";
 	import { createDispatcher } from "$lib/internal/events.js";
 
-	type $$Props = TriggerProps;
-	type $$Events = TriggerEvents;
+	type $$Props = CloseProps;
+	type $$Events = CloseEvents;
 	export let asChild = false;
 	const {
 		elements: { close }
@@ -20,6 +20,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/popover/components/PopoverTrigger.svelte

@@ -20,6 +20,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/popover/types.ts

@@ -25,7 +25,7 @@ type ContentProps<
 > = Expand<TransitionProps<T, In, Out> & AsChild> & HTMLDivAttributes;
 
 type TriggerProps = AsChild & HTMLButtonAttributes;
-type CloseProps = AsChild & HTMLButtonAttributes;
+type CloseProps = TriggerProps;
 
 type ArrowProps = Expand<
 	{

src/lib/bits/radio-group/components/RadioGroupItem.svelte

@@ -23,6 +23,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/select/components/SelectTrigger.svelte

@@ -20,6 +20,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/switch/components/Switch.svelte

@@ -53,6 +53,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/tabs/components/TabsTrigger.svelte

@@ -24,6 +24,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/tabs/types.ts

@@ -7,6 +7,7 @@ import type {
 	OmitValue,
 	OnChangeFn
 } from "$lib/internal/index.js";
+import type { HTMLButtonAttributes } from "svelte/elements";
 import type { CustomEventHandler } from "$lib/index.js";
 
 type Props = Expand<
@@ -25,7 +26,7 @@ type ContentProps = Expand<
 > &
 	HTMLDivAttributes;
 
-type TriggerProps = Expand<ObjectVariation<TabsTriggerProps> & AsChild> & HTMLDivAttributes;
+type TriggerProps = Expand<ObjectVariation<TabsTriggerProps> & AsChild> & HTMLButtonAttributes;
 
 type ListProps = AsChild & HTMLDivAttributes;
 

src/lib/bits/toggle/components/Toggle.svelte

@@ -40,6 +40,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-click={dispatch}

src/lib/bits/tooltip/components/TooltipTrigger.svelte

@@ -21,6 +21,7 @@
 {:else}
 	<button
 		use:melt={builder}
+		type="button"
 		{...$$restProps}
 		{...attrs}
 		on:m-blur={dispatch}