Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types #134

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Improve types #134

merged 2 commits into from
Oct 24, 2023

Conversation

huntabyte
Copy link
Owner

This update addresses annoying type issues with some of the onChange functions, where the value passed could possibly be undefined, even if impossible.

Some values could still possibly be undefined, such as the radio groups, etc., but most of them cannot.

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: d00bab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 11:47pm

@huntabyte huntabyte merged commit 2c406b2 into main Oct 24, 2023
4 checks passed
@huntabyte huntabyte deleted the improve/types branch October 24, 2023 23:50
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant