Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated ComboboxLabelProps to use HTMLLabelAttributes #544

Merged
merged 2 commits into from
May 17, 2024

Conversation

jeannemas
Copy link
Contributor

@jeannemas jeannemas commented May 15, 2024

Changed types since the attributes are applied to a <label> element and not a <div> element.

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: baed06b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 15, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview baed06b

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@huntabyte huntabyte merged commit 1691ef9 into huntabyte:main May 17, 2024
4 checks passed
This was referenced May 17, 2024
huntabyte added a commit that referenced this pull request Aug 3, 2024
Co-authored-by: Andre Morise <andre.morise@pax.us>
Co-authored-by: Hunter Johnston <64506580+huntabyte@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>
Co-authored-by: Andre Morise <andre.morise@gmail.com>
Co-authored-by: Magnar Ovedal Myrtveit <magnar@myrtveit.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Abdoulaye NDOYE <46305144+NDOY3M4N@users.noreply.github.com>
Co-authored-by: Jeanne Mas <24734881+jeannemas@users.noreply.github.com>
Co-authored-by: Mariusz Wachowski <wachowski.mariusz@gmail.com>
Co-authored-by: Ratul Maharaj <56479869+RatulMaharaj@users.noreply.github.com>
Fix binding button element (#473)
fix: ContentProps type (#545)
fix: Updated ComboboxLabelProps to use HTMLLabelAttributes (#544)
fix: allow overriding the combobox input id (#553)
fix: date pickers clear (#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants