-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated ComboboxLabelProps to use HTMLLabelAttributes #544
Merged
huntabyte
merged 2 commits into
huntabyte:main
from
jeannemas:origin/fix/combobox-types
May 17, 2024
Merged
fix: Updated ComboboxLabelProps to use HTMLLabelAttributes #544
huntabyte
merged 2 commits into
huntabyte:main
from
jeannemas:origin/fix/combobox-types
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: baed06b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
huntabyte
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This was referenced May 17, 2024
Merged
huntabyte
added a commit
that referenced
this pull request
Aug 3, 2024
Co-authored-by: Andre Morise <andre.morise@pax.us> Co-authored-by: Hunter Johnston <64506580+huntabyte@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com> Co-authored-by: Andre Morise <andre.morise@gmail.com> Co-authored-by: Magnar Ovedal Myrtveit <magnar@myrtveit.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Abdoulaye NDOYE <46305144+NDOY3M4N@users.noreply.github.com> Co-authored-by: Jeanne Mas <24734881+jeannemas@users.noreply.github.com> Co-authored-by: Mariusz Wachowski <wachowski.mariusz@gmail.com> Co-authored-by: Ratul Maharaj <56479869+RatulMaharaj@users.noreply.github.com> Fix binding button element (#473) fix: ContentProps type (#545) fix: Updated ComboboxLabelProps to use HTMLLabelAttributes (#544) fix: allow overriding the combobox input id (#553) fix: date pickers clear (#549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed types since the attributes are applied to a
<label>
element and not a<div>
element.