[HOTFIX] support download files with utf8 names #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daneryl
force-pushed
the
hotfix_3219_utf8_filenames
branch
from
3eff9b4 to
83dedb0
Compare
daneryl
force-pushed
the
hotfix_3219_utf8_filenames
branch
from
83dedb0 to
de31b4e
Compare
mfacar
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Great! thanks for solving :).
I've tested some scenarios and only for the record, found that when the filename contains a single quote the original name is ignored and the file is downloaded with the internal name (this behavior is not related with the encoding issue)
|
looks good to me too |
mfacar
added a commit
that referenced
this pull request
Sep 28, 2020
Merge pull request #3220 from huridocs/hotfix_3219_utf8_filenames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3219
PR checklist:
QA checklist: