Added support for date modified field on cards

[grafitto]

fixes #1893

PR checklist:

• Update READ.me ?
• Update API documentation ?

QA checklist:

• Smoke test the functionality described in the issue
• Test for side effects
• UI responsiveness
• Cross browser testing
• Code review

[daneryl]

some tests are failing, also some tests are missing, the details are in the code comments.

[daneryl]

does not work properly on already existing collections, to replicate.

• yarn blank state
• modify an entity
• sorting by date modified (recently or least recently) results on the modified entity showing on the last position.

maybe this needs a migration to add the date modified property ? @grafitto @RafaPolit ?

[grafitto]

does not work properly on already existing collections, to replicate.

• yarn blank state
• modify an entity
• sorting by date modified (recently or least recently) results on the modified entity showing on the last position.

maybe this needs a migration to add the date modified property ? @grafitto @RafaPolit ?

I think it needs migration...

[daneryl]

• yarn blank state
• modify an entity
• sorting by date modified (recently or least recently) results on the modified entity showing on the last position.

this is wrong, the proper way to replicate is to use existing data, (yarn fixtures, instead of blank-state)

[grafitto]

• yarn blank state
• modify an entity
• sorting by date modified (recently or least recently) results on the modified entity showing on the last position.

this is wrong, the proper way to replicate is to use existing data, (yarn fixtures, instead of blank-state)

Noted. After testing, I think the editDate property is not added when an entity is edited

[grafitto]

Only the entities with the editDate property are being sorted, the rest are not sorted and remain the same. If you edit more than one entities, you can actually see them getting sorted but the rest stay in the same position. @daneryl

[daneryl]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

[grafitto]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

Does this happen even after you run the migration?

[daneryl]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

Does this happen even after you run the migration?

yes, does it work properly for you ?

[grafitto]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

Does this happen even after you run the migration?

yes, does it work properly for you ?

Mine seems to work as expected. I run yarn migrate and yarn reindex, I am not sure if reindexing helps. You could try that

[daneryl]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

Does this happen even after you run the migration?

yes, does it work properly for you ?

Mine seems to work as expected. I run yarn migrate and yarn reindex, I am not sure if reindexing helps. You could try that

@grafitto this was an issue on my side, sorting is working properly now, im not sure what happened may be i forgot a reindex.

sorting apparently works properly but the date shown on the card for "Date modified" its always today not the actual date modified, it can be that the new field is somehow excluded from the results, please review.

[grafitto]

@grafitto migrations looks good.
i have noticed an issue where sorting by the new "date modified" results in the same order whether it is sorted by "recently" or "least recently"

Does this happen even after you run the migration?

yes, does it work properly for you ?

Mine seems to work as expected. I run yarn migrate and yarn reindex, I am not sure if reindexing helps. You could try that

@grafitto this was an issue on my side, sorting is working properly now, im not sure what happened may be i forgot a reindex.

sorting apparently works properly but the date shown on the card for "Date modified" its always today not the actual date modified, it can be that the new field is somehow excluded from the results, please review.

On it

[grafitto]

@daneryl I have added editDate to documentQueryBuilder, kindly check whether that fixes the issue