Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toc_generation service #3465
toc_generation service #3465
Changes from 1 commit
8ad80a4
282a5a0
60263ad
77b0532
2883177
bcdb188
baa08e5
42e7dfd
97405a3
ed1565a
2023a22
5f88a16
08bea1f
d1cb5d3
305f49a
5650300
8868f57
f632ead
eb09f2f
eba2caf
5928bb0
d8ef75b
adb875a
e0cff38
cc42af9
4967e1a
1cde69b
d87b298
aa2f46b
e1556b8
a32f998
97efec7
0a6cd50
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we moved away from creating scss files in the App folder namespaced by either component type or section type? Also, usually scss files are imported in a single place instead on a per-component basis. Is this actually working? We don't really have styled components, which would be ideal. But not sure this is the right approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure either, this definitely works, and it also make sense, the css go with the component, if you remove this component this css will not be part of the final build instead of having to remember that this have some associated specific css.