Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments mimetype #3516

Merged
merged 6 commits into from
Mar 15, 2021
Merged

Attachments mimetype #3516

merged 6 commits into from
Mar 15, 2021

Conversation

konzz
Copy link
Member

@konzz konzz commented Mar 11, 2021

fixes #

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@konzz konzz requested a review from fnocetti March 12, 2021 14:58
fnocetti
fnocetti reviewed Mar 12, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! Left one quick comment.
Proceeding to the QA.

app/shared/specs/JSONRequest.spec.js Show resolved Hide resolved
@fnocetti fnocetti merged commit 3622ba5 into development Mar 15, 2021
@fnocetti fnocetti deleted the attachments-mimetype branch March 15, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnocetti fnocetti fnocetti left review comments

Assignees

@fnocetti fnocetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konzz @fnocetti