Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configured uploadFile to be able to accept external cookie. #3534

Merged
merged 4 commits into from
Mar 19, 2021
Merged

Configured uploadFile to be able to accept external cookie. #3534

merged 4 commits into from
Mar 19, 2021

Conversation

RafaPolit
Copy link
Member

@RafaPolit RafaPolit commented Mar 16, 2021 •
edited
Loading

fixes #3532
fixes #3533

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@RafaPolit RafaPolit marked this pull request as ready for review March 18, 2021 14:05
@fnocetti fnocetti self-assigned this Mar 18, 2021
@fnocetti fnocetti self-requested a review March 18, 2021 17:30
fnocetti
fnocetti approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR LGTM! Nice job, I like the approach.
I'll try to perform a quick testing.

@fnocetti
Copy link
Contributor

fnocetti commented Mar 19, 2021 •
edited
Loading

Works like charm! Tested:
On a multitenant set-up using the default tenant as a master + 2 extra tenants as slaves.
Used different passwords for the admin users. Sync'ed 2 templates with different properties, attachments, documents, and used filter conditions for one of the slaves. Also custom uploads.
Everything looks just good.
Merging now.

@fnocetti fnocetti merged commit 9b13961 into development Mar 19, 2021
@daneryl daneryl deleted the 3532-JSONRequest-improvements branch June 16, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnocetti fnocetti fnocetti approved these changes

Assignees

@fnocetti fnocetti

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RafaPolit @fnocetti