Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3579 entity generated id property #3595

Merged
merged 37 commits into from
May 6, 2021
Merged

3579 entity generated id property #3595

merged 37 commits into from
May 6, 2021

Conversation

mfacar
Copy link
Collaborator

@mfacar mfacar commented Apr 12, 2021

fixes #3579

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@mfacar mfacar changed the title 3579 entity id generator field 3579 entity generated id property Apr 12, 2021
Mercy Falconí and others added 19 commits April 12, 2021 18:25
updated types
8713ebf
fixed broken tests
d17522d
showing generated id property at edition
df32679
refactor to fix codeclimate issue
9c611cc
removing elastic_mapping test
cbecf6a
adding id generator
e390e14
@mfacar
Merge branch 'development' into 3579-entity-id-generator-field
1b933e0
default value for generatedid property
875c39f
Merge branch 'development' of https://github.com/huridocs/uwazi into …
e291ea4 
…3579-entity-id-generator-field
Setting default generated Id at loadFetchedInReduxForm
9a1ff6a
Merge branch 'development' of https://github.com/huridocs/uwazi into …
3565ed0 
…3579-entity-id-generator-field
not render generatedid fields at publicform
297502b
Hidden properties for generatedId properties
c12252c
Merge branch 'development' of https://github.com/huridocs/uwazi into …
37fb0a8 
…3579-entity-id-generator-field
Avoid default property at metadata form
616cf92
updating selector
289e4ab
restore removed code by mistake
f56680a
excludes generatedid field at copy from
ca82c43
fixes broken tests
5062201
@mfacar mfacar marked this pull request as ready for review April 26, 2021 19:53
@mfacar mfacar requested a review from fnocetti April 27, 2021 18:37
fnocetti
fnocetti suggested changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfacar if this approach is the correct, then it LGTM but for a couple of comments. Let's present it to the team.
I still need to test this, on the while, please, take a look :)

app/react/Metadata/actions/actions.js Show resolved Hide resolved
app/shared/IDGenerator.ts Outdated Show resolved Hide resolved
@mfacar mfacar marked this pull request as draft April 28, 2021 20:42
@mfacar mfacar marked this pull request as ready for review April 29, 2021 15:08
@mfacar mfacar requested a review from fnocetti April 29, 2021 15:28
@fnocetti
Copy link
Contributor

fnocetti commented Apr 29, 2021 •
edited
Loading

@mfacar The functionality looks good en general. There's two bugs:

  • When using the ID field as a filter it doesn't work. It's not filtering and also shows [object Object] as in the image bellow when blank.

Screen Shot 2021-04-29 at 5 42 26 PM

  • CSV import is not generating the value. Used the following csv on the Document template (default):
title,generated id
con, GENID
sin,

The first one is taking the provided value while the second is staying empty.

Please check. Thanks!

@mfacar
Copy link
Collaborator Author

mfacar commented Apr 30, 2021

Good catches, thank you Fede, I'm working on them

@mfacar mfacar marked this pull request as draft April 30, 2021 00:51
@mfacar mfacar marked this pull request as ready for review May 3, 2021 23:41
@mfacar
Copy link
Collaborator Author

mfacar commented May 4, 2021

@fnocetti, the bugs are fixed, thanks for reporting them. I found a problem at the searching by this type of property which is also fixed. Please take a look.

fnocetti
fnocetti approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good job! Merging now

@fnocetti fnocetti merged commit 5c39a02 into development May 6, 2021
@fnocetti fnocetti deleted the 3579-entity-id-generator-field branch May 6, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnocetti fnocetti fnocetti approved these changes

Assignees

@fnocetti fnocetti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not-Unique ID field (20 pts)
2 participants
@mfacar @fnocetti