Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added scroll to language translation modal #3596

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Added scroll to language translation modal #3596

merged 2 commits into from
Apr 13, 2021

Conversation

grafitto
Copy link
Contributor

fixes #3591

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@grafitto grafitto marked this pull request as ready for review April 13, 2021 11:44
fnocetti
fnocetti approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fnocetti fnocetti merged commit 7ff0acc into development Apr 13, 2021
@grafitto grafitto deleted the 3591-add-a-scroll branch April 14, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnocetti fnocetti fnocetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modal does not have a scroll option to see the submit button when doing live translations (3 pts)
2 participants
@grafitto @fnocetti