denormalize inherited #3602
Merged
denormalize inherited #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konzz
force-pushed
the
3497-denormalize-inherited
branch
from
122f3e1 to
df4a6b7
Compare
daneryl
requested changes
Apr 19, 2021
There was a problem hiding this comment.
@konzz there is a couple issues.
- this development needs a migration for the already existing datasets
- selecting an inherited property that is not set on the target entity causes the app to crash. (im not sure this can happen on new data but its happening to me using fixtures and selecting as inherited a Mecanismo -> resumen)
- editing the original property does not updated inherited values on the entities that inherit the property.
daneryl
requested changes
Apr 20, 2021
app/api/migrations/migrations/38-denormalize-inherited/specs/38-denormalize-inherited.spec.js
Outdated
Show resolved
Hide resolved
app/api/migrations/migrations/38-denormalize-inherited/specs/38-denormalize-inherited.spec.js
Outdated
Show resolved
Hide resolved
daneryl
approved these changes
Apr 21, 2021
This was referenced May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3497
PR checklist:
QA checklist: