3598 - Custom page for entity view #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zasa-san
force-pushed
the
3598-custom-entity-view
branch
from
6938879 to
1ad6b5d
Compare
Zasa-san
added a commit
that referenced
this pull request
May 31, 2021
Zasa-san
added a commit
that referenced
this pull request
Jun 1, 2021
Zasa-san
added a commit
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3598
PR checklist:
QA checklist:
For MVP we handle editing/deleting pages used for entity view the following way:
If a user wants to stop using an existing page as entity view, and they try to toggle off the functionality on the page editor or delete the page, they will get an error message explaining that the page is in use with a list of the templates using them. This way they can remove the page from the templates using it, then proceed to toggle entity view off or delete it.