Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added async validation to the templates to check the thesauri exists #3625

Merged
merged 5 commits into from
Apr 28, 2021
Merged

Added async validation to the templates to check the thesauri exists #3625

merged 5 commits into from
Apr 28, 2021

Conversation

konzz
Copy link
Member

@konzz konzz commented Apr 26, 2021

fixes #1003

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@mfacar mfacar self-assigned this Apr 26, 2021
mfacar
mfacar requested changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@mfacar mfacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I just have a doubt respect the message, please review the comments.

app/api/templates/specs/fixtures.js Show resolved Hide resolved
app/shared/types/templateSchema.ts Show resolved Hide resolved
@mfacar mfacar merged commit 652f81a into development Apr 28, 2021
@mfacar mfacar deleted the 1003-thesauri-content-validation branch April 28, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfacar mfacar mfacar requested changes

Assignees

@mfacar mfacar

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@konzz @mfacar