Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3630 public form with access levels #3631

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

mfacar
Copy link
Collaborator

@mfacar mfacar commented Apr 27, 2021

fixes #3630

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@mfacar mfacar marked this pull request as ready for review April 27, 2021 19:46
@mfacar mfacar requested a review from daneryl April 28, 2021 14:41
Copy link
Collaborator

@daneryl daneryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfacar i do not understand what is the cause of loosing the session and what is the fix, can you briefly explain ?

app/api/entities/specs/entities.spec.js Outdated Show resolved Hide resolved
@mfacar
Copy link
Collaborator Author

mfacar commented Apr 29, 2021

@mfacar i do not understand what is the cause of loosing the session and what is the fix, can you briefly explain ?

There is not a loss of session, basically, the error is when an entity is saved from the public endpoint without a user logged. It should be allowed, however, obviously, it cannot be a trace of any user at permissions, thus the rest of the implementation of saving fails.

@daneryl
Copy link
Collaborator

daneryl commented Apr 30, 2021

There is not a loss of session, basically, the error is when an entity is saved from the public endpoint without a user logged. It should be allowed, however, obviously, it cannot be a trace of any user at permissions, thus the rest of the implementation of saving fails.

@mfacar understood, i mixed up issues !, looks good !

@daneryl daneryl merged commit f0692f6 into feature/access-levels Apr 30, 2021
@daneryl daneryl deleted the 3630-access-levels-public-form-error branch April 30, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating new entities through a submission form with a logged-out user breaks the app
2 participants