Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hidding label in sidebar and entity view #3635

Merged
merged 4 commits into from
Apr 30, 2021
Merged

Allow hidding label in sidebar and entity view #3635

merged 4 commits into from
Apr 30, 2021

Conversation

fnocetti
Copy link
Contributor

fixes #3616

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@fnocetti fnocetti marked this pull request as draft April 28, 2021 18:48
@fnocetti fnocetti marked this pull request as ready for review April 28, 2021 19:22
daneryl
daneryl requested changes Apr 29, 2021
View reviewed changes
Copy link
Collaborator

@daneryl daneryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnocetti all looks good, there is just a small request on the code :)

app/react/Metadata/components/specs/__snapshots__/ShowMetadata.spec.js.snap Outdated Show resolved Hide resolved
@daneryl daneryl self-assigned this Apr 29, 2021
@fnocetti fnocetti requested a review from daneryl April 29, 2021 18:21
@daneryl daneryl merged commit 6a57381 into development Apr 30, 2021
@daneryl daneryl deleted the 3616-hide-label branch April 30, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneryl daneryl daneryl approved these changes

Assignees

@daneryl daneryl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide label option should also work in entity view and side panel (3 pts)
2 participants
@fnocetti @daneryl