Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3655 translations for identified as not translatable labels #3675

Merged
merged 13 commits into from
May 31, 2021
Merged

3655 translations for identified as not translatable labels #3675

merged 13 commits into from
May 31, 2021

Conversation

mfacar
Copy link
Collaborator

@mfacar mfacar commented May 20, 2021

fixes #3655

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@mfacar mfacar marked this pull request as ready for review May 25, 2021 03:09
@mfacar mfacar requested a review from grafitto May 25, 2021 15:24
daneryl
daneryl requested changes May 26, 2021
View reviewed changes
Copy link
Collaborator

@daneryl daneryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!, i have only to say that i think you should use instead of the t function in some new places you added translation.

app/react/Forms/components/Geolocation.js Outdated
@@ -100,7 +101,7 @@ export default class Geolocation extends Component {
/>
</div>
<div className="form-group half-width">
<label>Longitude</label>
<label>{t('System', 'Longitude')}</label>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not Translate component here ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, I changed it

@mfacar mfacar requested a review from daneryl May 26, 2021 22:12
@grafitto
Copy link
Contributor

@mfacar I just realize clear filters is not translatable as well, is it something that could be done before merging?
image

@mfacar
Copy link
Collaborator Author

mfacar commented May 27, 2021

@mfacar I just realize clear filters is not translatable as well, is it something that could be done before merging?

@grafitto It's weird, I just checked and it's showing well for me, this is the changed line. I think this is the only place in the application that has that label 🤔

@grafitto
Copy link
Contributor

@mfacar I just realize clear filters is not translatable as well, is it something that could be done before merging?

@grafitto It's weird, I just checked and it's showing well for me, this is the changed line. I think this is the only place in the application that has that label thinking

okay. just an update on the branch and i will merge

@grafitto grafitto merged commit 7ba015f into development May 31, 2021
@daneryl daneryl deleted the 3655-translate-labels branch June 3, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafitto grafitto Awaiting requested review from grafitto

@daneryl daneryl Awaiting requested review from daneryl

Assignees

@grafitto grafitto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some detected labels in the ui are not translatable. (2 pts)
3 participants
@mfacar @grafitto @daneryl