Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch indexing with query that contains _id #3676

Merged
merged 3 commits into from
May 24, 2021

Conversation

mfacar
Copy link
Collaborator

@mfacar mfacar commented May 21, 2021

fixes #

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@mfacar mfacar marked this pull request as ready for review May 21, 2021 20:39
@mfacar mfacar requested a review from fnocetti May 21, 2021 20:39
@fnocetti
Copy link
Contributor

@mfacar This LGTM. I tested the issue reported: it's easily reproducible in the development branch and fixed here. Also the solution implemented is clear.
While I think this should work in every case, I'm not sure what other cases should be tested so I'll wait for @RafaPolit or @daneryl to take a look.

@daneryl
Copy link
Collaborator

daneryl commented May 24, 2021

@mfacar LGTM, i have tested it with diferent datasets. im merging this, still i think we should write tests for this. im creating a tech debt for this.

@daneryl daneryl merged commit 2b5530a into release May 24, 2021
@mfacar mfacar deleted the PatchFix-update-masive-permisions branch June 30, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants