Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOTFIX, crons now run with permissions command context #3689

Merged
merged 2 commits into from
May 25, 2021
Merged

HOTFIX, crons now run with permissions command context #3689

merged 2 commits into from
May 25, 2021

Conversation

daneryl
Copy link
Collaborator

@daneryl daneryl commented May 25, 2021

fixes #3686

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@daneryl daneryl requested a review from fnocetti May 25, 2021 13:48
@daneryl daneryl self-assigned this May 25, 2021
@daneryl daneryl marked this pull request as ready for review May 25, 2021 15:38
fnocetti
fnocetti approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@fnocetti fnocetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fnocetti fnocetti merged commit 1bd93b8 into master May 25, 2021
@daneryl daneryl deleted the crons_with_permisssions_fix branch May 26, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnocetti fnocetti fnocetti approved these changes

Assignees

@daneryl daneryl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daneryl @fnocetti