Hotfix 3702 perf issues round 2

[fnocetti]

fixes #3702

This replaces #3736

PR checklist:

• Update READ.me ?
• Update API documentation ?

QA checklist:

• Smoke test the functionality described in the issue
• Test for side effects
• UI responsiveness
• Cross browser testing
• Code review

[RafaPolit]

I cannot edit a thesaurus item on previously existing data (perhaps due to certain scenario?). This was not happening yesterday.

To Reproduce

• Restore data from collection "best-artworks"
• Migrate & reindex
• Try to edit a value inside Thesaurus "Genre" (I have tried with a few, all give an error, but the first one is a good try)

Error:

TypeError: Cannot read property 'toString' of undefined
    at /home/rafapolit/workspace/uwazi/app/api/entities/entities.js:766:43
    at Array.filter (<anonymous>)
    at Object.renameThesaurusInMetadata (/home/rafapolit/workspace/uwazi/app/api/entities/entities.js:766:5)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async Promise.all (index 0)
    at async updateOptionsInEntities (/home/rafapolit/workspace/uwazi/app/api/thesauri/thesauri.js:80:3)
    at async update (/home/rafapolit/workspace/uwazi/app/api/thesauri/thesauri.js:94:5)
    at async /home/rafapolit/workspace/uwazi/app/api/thesauri/routes.js:47:22

Note: If I create a NEW thesaurus, NEW template, and assign the thesaurus, and then edit it, it works. It could be an issue of collections with existing data, it could be due to the size of the thesaurus, the amount of entities, it could be the fact that the entities have multiple selects... many other variables. Please, use the dataset described to diagnose and debug.

[RafaPolit]

Other tests are successful, but I am very limited in what I can try without the ability to edit thesauri.

[daneryl]

@RafaPolit @fnocetti

I cannot edit a thesaurus item on previously existing data (perhaps due to certain scenario?). This was not happening yesterday.

this is fixed, we were forced to remove p.content?.toString() because we do not have support in master yet. this was the cause. i have added a small test and a manual check of p.content.