Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3242 slow csv import with thesaurus creation #3927

Merged
merged 26 commits into from
Sep 29, 2021
Merged

3242 slow csv import with thesaurus creation #3927

merged 26 commits into from
Sep 29, 2021

Conversation

LaszloKecskes
Copy link
Contributor

@LaszloKecskes LaszloKecskes commented Sep 21, 2021 •
edited
Loading

fixes #3242

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@LaszloKecskes LaszloKecskes marked this pull request as draft September 21, 2021 11:56
@LaszloKecskes LaszloKecskes marked this pull request as ready for review September 22, 2021 12:49
@LaszloKecskes LaszloKecskes marked this pull request as draft September 23, 2021 06:04
@LaszloKecskes LaszloKecskes marked this pull request as ready for review September 23, 2021 13:19
daneryl
daneryl requested changes Sep 24, 2021
View reviewed changes
app/api/csv/importEntity.ts Outdated Show resolved Hide resolved
app/api/csv/importEntity.ts Outdated Show resolved Hide resolved
app/api/csv/importEntity.ts Outdated Show resolved Hide resolved
app/api/csv/importEntity.ts Outdated Show resolved Hide resolved
app/api/csv/specs/importEntity.spec.js Outdated Show resolved Hide resolved
app/api/csv/specs/csvLoader.spec.js Outdated Show resolved Hide resolved
daneryl
daneryl requested changes Sep 28, 2021
View reviewed changes
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/csvLoader.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
app/api/csv/arrangeThesauri.ts Outdated Show resolved Hide resolved
@daneryl
Copy link
Collaborator

daneryl commented Sep 29, 2021

LGTM

@daneryl daneryl merged commit d3fe0eb into development Sep 29, 2021
@daneryl daneryl deleted the 3242_slow_csv_import_with_thesaurus_creation branch September 29, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daneryl daneryl daneryl requested changes

Assignees

@daneryl daneryl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import CSV slows down if creation of thesaurus values is needed [timebox 1 day]
2 participants
@LaszloKecskes @daneryl