Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Taking in to account nested templates for filters #4010

Merged
merged 3 commits into from
Nov 10, 2021
Merged

[Hotfix] Taking in to account nested templates for filters #4010

merged 3 commits into from
Nov 10, 2021

Conversation

konzz
Copy link
Member

@konzz konzz commented Nov 10, 2021

fixes #4009

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@konzz konzz changed the base branch from development to master November 10, 2021 14:25
mfacar
mfacar requested changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@mfacar mfacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konzz I checked the functionality and all is ok. Please review the comments I put in the code.

app/react/Library/components/TemplatesFilter.tsx Outdated Show resolved Hide resolved
app/react/Library/components/TemplatesFilter.tsx Outdated Show resolved Hide resolved
mfacar
mfacar approved these changes Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@mfacar mfacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfacar mfacar merged commit 28b5b40 into master Nov 10, 2021
@daneryl daneryl deleted the 4009-hotfix-filters branch June 16, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfacar mfacar mfacar approved these changes

Assignees

@mfacar mfacar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotfix Grouped filters not rendering as checked.
2 participants
@konzz @mfacar