Move dateToSeconds function behind an endpoint #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafitto
force-pushed
the
4879-click-to-fill-date
branch
from
63b89d6 to
da59a2b
Compare
daneryl
added a commit
that referenced
this pull request
Aug 1, 2022
* Upload attachments * Remove keys * storage readableFile and fileContents * undo s3 spike on uploadMiddleware * redirect staticFilesMiddleware to /api/files * file deprecated routes now redirect to /api/files * fix lints and types * unignore a testing file for specs * Mimetype on thumbnail creation and default mimetype serving files * Remove direct access to filesystem * Redirect old attachments route to files download route * Remove unused imports * fileContents tweak to use readableFile * spike on uplading readed files to s3 when reading * reading a file stores it on s3 if not stored * added minio to docker-compose * s3 featureFlag per tenant * use last portion of the path to store s3 object * fix function cognitive complexity * minio for api_unit_tests ci * try unificial minio image for github ci * test only storage_s3_upload_on_read, more timeout * use 127.0.0.1 ip on s3 tests * run all api testa again * Move dateToSeconds function behind an endpoint (#4937) * Updated dateToSeconds function * Removed dateToSeconds to dataUtils * Moved dateToSecond function to the server * Renamed date.ts back to date.js * Added endpoint * Updated frontend to use date to seconds endpoint * Added an action to get seconds from date string * Fixed tests * Updated server dateToSeconds tests * Put entity suggestion if suggestion language is not found * Moved dateToSeconds call to coerceValue call on front end * Added coerce-values endoint instead of date-to-seconds in the server * Added a migration Co-authored-by: Sergio Revilla <sergio@huridocs.org> Co-authored-by: Kevin Nderitu <nderitukelvin19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4879
PR checklist:
QA checklist: