Fix/160 invalid date format on import csv #7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daneryl
force-pushed
the
fix/160-invalid-date-format-on-import-csv
branch
from
d567e84 to
e71a2a1
Compare
RafaPolit
reviewed
Dec 16, 2024
app/api/csv/importEntity.ts
Outdated
Comment on lines
1
to
3
| /* eslint-disable no-await-in-loop */ | ||
| /* eslint-disable no-unreachable-loop */ | ||
| /* eslint-disable no-restricted-syntax */ |
There was a problem hiding this comment.
We really cannot put exceptions to es-lints like this. The fact that this practice has happened before should not be followed these days. So, please, remove this exceptions and lets fix the code to not have these eslint warnings:
To solve this, please create a reduce with an async callback.
Also, the no-unreachable-loop is not really solving any warning, so this was probably a previous version of the code which is no longer present, all the more reason not to include this exceptions that can later be left in the header of the file and we end up with code that is against our own guidelines.
…m:huridocs/uwazi into fix/160-invalid-date-format-on-import-csv
This reverts commit efc5f1c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request was created based on this [issue] (https://github.com/huridocs/Internal-Issues/issues/160)
Problem
We were not respecting the date format, defined at settings -> collections, to import Dates in the translated versions of the Entities.