Add ex-lock utils setupVF finished #17
Conversation
|
Hi @okletswin, Can you explain the problem in your setupVF ? |
|
fixup #16 |
sriov/sriov.go
Outdated
| @@ -29,6 +29,7 @@ func setupVF(conf *SriovConf, ifName string, netns ns.NetNS) error { | |||
| var ( | |||
| err error | |||
| vfDevName string | |||
| locker *FileLocker | |||
There was a problem hiding this comment.
How about make locker as global variable and initialize it in init function?
sriov/sriov.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| } else { | ||
| // alloc a free virtual function | ||
| if vfIdx, vfDevName, err = allocFreeVF(masterName); err != nil { | ||
| if vfIdx, vfDevName, locker, err = allocFreeVF(masterName); err != nil { |
There was a problem hiding this comment.
Maybe have no need to change allocFreeVF function, We can change it as follows:
locker.Lock()
allocFreeVF()
locker.UnLock()
There was a problem hiding this comment.
yes, It's more better implementation. locker is global, Lock() maybe need an angument vfId and make it saved, Unlock() free the vfId and opened file. I will try
still make lock in getVFDeviceName
|
@hustcat , I pushed a new commit, and due to my level of golang is pitiful, some places are not too standard, improve it as you want |
|
@okletswin I made some changes, PTAL |
|
@hustcat |
|
哥，什么情况，咋么还没合并呢？？？ |
|
@okletswin There are some conflicts, could you like to fix it? |
|
@hustcat |
|
IMO, in order to support high concurrency allocate VF, this file level lock is MUST....... |
Sometimes, process allocated a free vf, but got error 'device not found' while setup it.
so, add a lock while find a free vf, other process will continue finding another free vf for use