Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squarify does not work with ie11 #79

Closed
sumboxcar182 opened this issue Feb 6, 2019 · 5 comments
Closed

Squarify does not work with ie11 #79

sumboxcar182 opened this issue Feb 6, 2019 · 5 comments
Labels

Comments

@sumboxcar182
Copy link

Hello!

We just started to use this package and we found that there are syntax errors when running this in ie11. I've confirmed that it is the package, and it looks like the code that is being emitted is still using es6 features. I double checked the site that is listed in the readme and it suffers from the same issue we are hitting.

@huy-nguyen
Copy link
Owner

This package contains 3 build versions: untranspiled ES module (in es directory), untranspiled CommonJS module (in lib) and UMD build (in dist). Would transpiling the UMD build to work with IE11 be sufficient for your need?

@sumboxcar182
Copy link
Author

Hello Huy!

Thank you so much for the quick response! So i pulled in the UMD build and gave it a shot and it's still failing. The UMD build still contains some es6 level code, including the => operator, which IE11 is having issues with.

So i wish i could just use the UMD bundle, but it seems like it's still giving me trouble

@huy-nguyen
Copy link
Owner

I'll make a new version whose UMD build is transpiled down to ES5 level.

@huy-nguyen
Copy link
Owner

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sumboxcar182
Copy link
Author

I just saw this now, i cannot thank you enough for the quick fix!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants