Merge pull request #1412 from hydephp/set-build-flag-in-runtime-confi…

…guration Add runtime configuration option for the `--no-api` build flag
hydephp · Oct 28, 2023 · 285f819 · 285f819
2 parents c00dbf4 + 492da4a
commit 285f819
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/packages/framework/src/Foundation/Internal/LoadConfiguration.php b/packages/framework/src/Foundation/Internal/LoadConfiguration.php
@@ -85,6 +85,11 @@ private function loadRuntimeConfiguration(Application $app, RepositoryContract $
             if (in_array('--pretty-urls', $_SERVER['argv'], true)) {
                 $repository->set('hyde.pretty_urls', true);
             }
+
+            // Check if the `--no-api` CLI argument is set, and if so, set the config value accordingly.
+            if (in_array('--no-api', $_SERVER['argv'], true)) {
+                $repository->set('hyde.api_calls', false);
+            }
         }
     }
 }
diff --git a/packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php b/packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php
@@ -13,7 +13,6 @@
 use Hyde\Framework\Exceptions\FileNotFoundException;
 use Hyde\Markdown\Contracts\FrontMatter\SubSchemas\FeaturedImageSchema;
 
-use function in_array;
 use function array_key_exists;
 use function array_flip;
 use function file_exists;
@@ -226,7 +225,7 @@ protected function getContentLengthForLocalImage(): int
     protected function getContentLengthForRemoteImage(): int
     {
         // Check if the --no-api flag is set when running the build command, and if so, skip the API call.
-        if (! (isset($_SERVER['argv']) && in_array('--no-api', $_SERVER['argv'], true))) {
+        if (Config::getBool('hyde.api_calls', true)) {
             $headers = Http::withHeaders([
                 'User-Agent' => Config::getString('hyde.http_user_agent', 'RSS Request Client'),
             ])->head($this->getSource())->headers();

diff --git a/packages/framework/tests/Unit/LoadConfigurationTest.php b/packages/framework/tests/Unit/LoadConfigurationTest.php
@@ -17,18 +17,20 @@ public function testItLoadsRuntimeConfiguration()
     {
         $serverBackup = $_SERVER;
 
-        $_SERVER['argv'] = ['--pretty-urls'];
+        $_SERVER['argv'] = ['--pretty-urls', '--no-api'];
 
         $app = new Application(getcwd());
 
         $loader = new LoadConfiguration();
         $loader->bootstrap($app);
 
         $this->assertTrue(config('hyde.pretty_urls'));
+        $this->assertFalse(config('hyde.api_calls'));
 
         $_SERVER = $serverBackup;
 
         $loader->bootstrap($app);
         $this->assertFalse(config('hyde.pretty_urls'));
+        $this->assertNull(config('hyde.api_calls'));
     }
 }