Generated pubtype field names should be lower/kebab case

Generated PublicationFieldType field names should be lower/kebab case to match the constructor normalization made in the PublicationFieldType class _Originally posted by @caendesilva in #685 (comment)
hydephp · Dec 4, 2022 · 57fdf70 · 57fdf70
1 parent 42ce1d6
commit 57fdf70
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/framework/src/Console/Commands/MakePublicationTypeCommand.php b/packages/framework/src/Console/Commands/MakePublicationTypeCommand.php
@@ -113,7 +113,7 @@ protected function captureFieldsDefinitions(): Collection
 
             $field = Collection::create();
             do {
-                $field->name = trim($this->askWithValidation('name', 'Field name', ['required']));
+                $field->name = Str::kebab(trim($this->askWithValidation('name', 'Field name', ['required'])));
                 $duplicate = $fields->where('name', $field->name)->count();
                 if ($duplicate) {
                     $this->error("Field name [$field->name] already exists!");

diff --git a/packages/framework/tests/Feature/Commands/MakePublicationTypeCommandTest.php b/packages/framework/tests/Feature/Commands/MakePublicationTypeCommandTest.php
@@ -18,7 +18,7 @@ public function test_command_creates_publication_type()
     {
         $this->artisan('make:publicationType')
             ->expectsQuestion('Publication type name', 'Test Publication')
-            ->expectsQuestion('Field name', 'Title')
+            ->expectsQuestion('Field name', 'Publication Title')
             ->expectsQuestion('Field type (1-10)', 1)
             ->expectsQuestion('Min value (for strings, this refers to string length)', 'default')
             ->expectsQuestion('Max value (for strings, this refers to string length)', 'default')
@@ -41,7 +41,7 @@ public function test_command_creates_publication_type()
             <<<'JSON'
             {
                 "name": "Test Publication",
-                "canonicalField": "Title",
+                "canonicalField": "publication-title",
                 "sortField": "__createdAt",
                 "sortDirection": "ASC",
                 "pageSize": 10,
@@ -50,7 +50,7 @@ public function test_command_creates_publication_type()
                 "listTemplate": "test-publication_list",
                 "fields": [
                     {
-                        "name": "Title",
+                        "name": "publication-title",
                         "min": "default",
                         "max": "default",
                         "type": "string"