Merge pull request #1321 from hydephp/fix-rss-feed-generator-not-resp…

…ecting-the-no-api-flag

Update FeaturedImage class to only make API calls when not disabled

RELEASE_NOTES.md

@@ -23,6 +23,7 @@ This release is the first since the official release of HydePHP 1.0.0. It contai
 - Fixed https://github.com/hydephp/develop/issues/1313 in https://github.com/hydephp/develop/commit/134776a1e4af395dab5c15d611fc64c9ebce8596
 - Fixed https://github.com/hydephp/develop/issues/1316 in https://github.com/hydephp/develop/pull/1317
 - Fixed https://github.com/hydephp/develop/issues/1318 in https://github.com/hydephp/develop/pull/1319
+- Fixed https://github.com/hydephp/develop/issues/1320 in https://github.com/hydephp/develop/pull/1321
 - Added missing function imports in https://github.com/hydephp/develop/pull/1309
 
 ### Security

packages/framework/src/Framework/Features/Blogging/Models/FeaturedImage.php

@@ -13,6 +13,7 @@
 use Hyde\Framework\Exceptions\FileNotFoundException;
 use Hyde\Markdown\Contracts\FrontMatter\SubSchemas\FeaturedImageSchema;
 
+use function in_array;
 use function array_key_exists;
 use function array_flip;
 use function file_exists;
@@ -224,15 +225,20 @@ protected function getContentLengthForLocalImage(): int
 
     protected function getContentLengthForRemoteImage(): int
     {
-        $headers = Http::withHeaders([
-            'User-Agent' => Config::getString('hyde.http_user_agent', 'RSS Request Client'),
-        ])->head($this->getSource())->headers();
+        // TODO: We may want to globalize this check in the config, but for now,
+        // we just check the server arguments and skip remote requests if
+        // the --no-api flag is present (in the build command call)
+        if (! (isset($_SERVER['argv']) && in_array('--no-api', $_SERVER['argv'], true))) {
+            $headers = Http::withHeaders([
+                'User-Agent' => Config::getString('hyde.http_user_agent', 'RSS Request Client'),
+            ])->head($this->getSource())->headers();
 
-        if (array_key_exists('Content-Length', $headers)) {
-            return (int) key(array_flip($headers['Content-Length']));
-        }
+            if (array_key_exists('Content-Length', $headers)) {
+                return (int) key(array_flip($headers['Content-Length']));
+            }
 
-        BuildWarnings::report('The image "'.$this->getSource().'" has a content length of zero.');
+            BuildWarnings::report('The image "'.$this->getSource().'" has a content length of zero.');
+        }
 
         return 0;
     }