Remove END_TOC marker search against closing </ul> tag

hydephp · Mar 22, 2023 · f00e27a · f00e27a
1 parent 61309e1
commit f00e27a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/framework/src/Framework/Actions/GeneratesTableOfContents.php b/packages/framework/src/Framework/Actions/GeneratesTableOfContents.php
@@ -49,9 +49,9 @@ public function execute(): string
         $environment->addExtension(new TableOfContentsExtension());
 
         $converter = new MarkdownConverter($environment);
-        $html = $converter->convert("[[END_TOC]]\n".$this->markdown)->getContent();
+        $html = $converter->convert($this->markdown)->getContent();
 
-        // Return everything before the [[END_TOC]] marker.
-        return substr($html, 0, strpos($html, '<p>[[END_TOC]]'));
+        // Return everything before the closing </ul> tag
+        return substr($html, 0, strpos($html, '</ul>') + 5);
     }
 }
diff --git a/packages/framework/tests/Feature/Actions/GeneratesSidebarTableOfContentsTest.php b/packages/framework/tests/Feature/Actions/GeneratesSidebarTableOfContentsTest.php
@@ -25,7 +25,7 @@ public function testCanGenerateTableOfContents()
         $this->assertIsString($result);
         $this->assertStringContainsString('<ul>', $result);
         $this->assertStringContainsString('<a href="#level-2">Level 2</a>', $result);
-        $this->assertStringNotContainsString('[[END_TOC]]', $result);
+        $this->assertStringContainsString('</ul>', $result);
     }
 
     public function testReturnStringContainsExpectedContent()