Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IDE helpers for removed global variables from the IDE helper file #1274

Merged
merged 6 commits into from
Mar 14, 2023
Merged

Remove IDE helpers for removed global variables from the IDE helper file #1274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ef9962
Remove IDE helpers for removed global variables from the IDE helper file
caendesilva Mar 14, 2023
67aa5b4
Update RELEASE_NOTES.md
caendesilva Mar 14, 2023
155c5a2
Merge branch 'master' into remove-removed-helpers-from-ide-helper
caendesilva Mar 14, 2023
f827334
Remove extra star from PHPDoc comment
caendesilva Mar 14, 2023
639a551
Merge branch 'remove-removed-helpers-from-ide-helper' of github.com:h…
caendesilva Mar 14, 2023
0fd69c0
Fix PHPDoc annotations not using same variable name as variable
caendesilva Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This serves two purposes:
- for soon-to-be removed features.

### Removed
- for now removed features.
- Removed IDE helpers for removed global variables from the IDE helper file. https://github.com/hydephp/develop/pull/1274

### Fixed
- for any bug fixes.
Expand Down
16 changes: 2 additions & 14 deletions _ide_helper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,10 @@
/** @var \Hyde\Pages\Concerns\HydePage $page The page being compiled/previewed */
$page = \Hyde\Support\Facades\Render::getPage();

/**
* @var \Hyde\Support\Models\Route $currentRoute The route for the page being compiled/previewed
* @deprecated Renamed to $route as "current" is implied
*/
$currentRoute = \Hyde\Support\Facades\Render::getRoute();

/**
* @var string $currentPage The route key for the page being compiled/previewed
* @deprecated Renamed to $routeKey as "current" is implied, and it's not a page
*/
$currentPage = \Hyde\Support\Facades\Render::getRouteKey();

/*** @var \Hyde\Support\Models\Route $currentRoute The route for the page being compiled/previewed */
/** @var \Hyde\Support\Models\Route $route The route for the page being compiled/previewed */
$route = \Hyde\Support\Facades\Render::getRoute();

/** @var string $currentPage The route key for the page being compiled/previewed */
/** @var string $routeKey The route key for the page being compiled/previewed */
$routeKey = \Hyde\Support\Facades\Render::getRouteKey();

// Facades (aliased in app/config.php)
Expand Down