Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generics to the Hyde facade method annotations #1280

Merged
merged 3 commits into from
Mar 14, 2023

Conversation

caendesilva
Copy link
Member

No description provided.

@caendesilva caendesilva marked this pull request as ready for review March 14, 2023 11:37
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1280 (06a0a64) into master (ba3d9cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 06a0a64 differs from pull request most recent head 8279119. Consider uploading reports for the commit 8279119 to get more accurate results

@@              Coverage Diff              @@
##              master     #1280     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1314      2628   +1314     
=============================================
  Files            152       304    +152     
  Lines           3450      6900   +3450     
=============================================
+ Hits            3450      6900   +3450     
Impacted Files Coverage Δ
packages/framework/src/Hyde.php 100.00% <ø> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit b38c08d into master Mar 14, 2023
@caendesilva caendesilva deleted the improve-generic-type-usage branch March 14, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant