Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "HydePHP" as the application logo when running without ANSI formatting #1288

Merged

Conversation

caendesilva
Copy link
Member

Fixes #1127

@caendesilva caendesilva linked an issue Mar 14, 2023 that may be closed by this pull request
@caendesilva caendesilva force-pushed the list-command-logo-should-respect-the-no-ansi-setting branch from c12f7d5 to 2b2e655 Compare March 14, 2023 16:10
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@fd416d0). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             master     #1288   +/-   ##
==========================================
  Coverage          ?   100.00%           
  Complexity        ?      2638           
==========================================
  Files             ?       304           
  Lines             ?      6908           
  Branches          ?         0           
==========================================
  Hits              ?      6908           
  Misses            ?         0           
  Partials          ?         0           
Impacted Files Coverage Δ
...s/framework/src/Console/ConsoleServiceProvider.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 14, 2023 16:20
@caendesilva caendesilva merged commit 71e9334 into master Mar 14, 2023
@caendesilva caendesilva deleted the list-command-logo-should-respect-the-no-ansi-setting branch March 14, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HydeCLI list command logo should respect the --no-ansi setting
2 participants