Skip unit test when not running in the monorepo #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unrelated test failures in hydephp/framework#572. We mostly have this check to catch any mistakes before merging config changes when developing in the monorepo.
caendesilva
force-pushed
the
skip-unit-test-when-not-running-in-monorepo
branch
from
ec661bf to
9061783
Compare
caendesilva
added a commit
to hydephp/framework
that referenced
this pull request
Mar 20, 2023
Verifies the fix is working
Codecov Report
@@ Coverage Diff @@
## master #1339 +/- ##
=============================================
Coverage 100.00% 100.00%
- Complexity 1332 2664 +1332
=============================================
Files 152 304 +152
Lines 3474 6948 +3474
=============================================
+ Hits 3474 6948 +3474 see 152 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Fix is verified to be effective in hydephp/framework#572 / hydephp/framework@a70f353 |
This was referenced Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unrelated test failures in hydephp/framework#572. We mostly have this check to catch any mistakes before merging config changes when developing in the monorepo.