Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change root monorepo Composer name to hyde/monorepo #1361

Merged
merged 6 commits into from
Mar 28, 2023

Conversation

caendesilva
Copy link
Member

This composer file has become widely different from the actual hyde/hyde composer file, so it doesn't make semantic sense for this project to be branded the same way as the hyde/hyde package. This change is not breaking, as the monorepo structure is not included in the HydePHP BC promise.

This composer file has become widely different from the actual hyde/hyde composer file, so it doesn't make semantic sense for this project to be branded the same way as the hyde/hyde package. This change is not breaking, as the monorepo structure is not included in the HydePHP BC promise.
@caendesilva caendesilva force-pushed the split-out-monorepo-composer-file branch from 1c8bef7 to 2eaf258 Compare March 28, 2023 10:47
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #1361 (681482d) into master (2aed568) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 681482d differs from pull request most recent head 16ff613. Consider uploading reports for the commit 16ff613 to get more accurate results

@@             Coverage Diff             @@
##             master    #1361     +/-   ##
===========================================
  Coverage     99.97%   99.97%             
- Complexity     1338     2678   +1340     
===========================================
  Files           152      304    +152     
  Lines          3489     6978   +3489     
===========================================
+ Hits           3488     6976   +3488     
- Misses            1        2      +1     
Impacted Files Coverage Δ
...es/framework/src/Console/Commands/DebugCommand.php 100.00% <100.00%> (ø)

... and 152 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review March 28, 2023 11:14
@caendesilva caendesilva merged commit dab7ab7 into master Mar 28, 2023
@caendesilva caendesilva deleted the split-out-monorepo-composer-file branch March 28, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant