Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch RealtimeCompiler dashboard OutOfBoundsException #1384

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Catch RealtimeCompiler dashboard OutOfBoundsException #1384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions packages/realtime-compiler/src/Http/DashboardController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Hyde\RealtimeCompiler\Http;

use Hyde\Hyde;
use OutOfBoundsException;
use Hyde\Pages\Concerns\HydePage;
use Hyde\Framework\Actions\StaticPageBuilder;
use Hyde\Framework\Actions\AnonymousViewCompiler;
Expand Down Expand Up @@ -46,8 +47,8 @@ public function getProjectInformation(): array
{
return [
'Git Version:' => app('git.version'),
'Hyde Version:' => InstalledVersions::getPrettyVersion('hyde/hyde') ?: 'unreleased',
'Framework Version:' => InstalledVersions::getPrettyVersion('hyde/framework') ?: 'unreleased',
'Hyde Version:' => self::getPackageVersion('hyde/hyde'),
'Framework Version:' => self::getPackageVersion('hyde/framework'),
'Project Path:' => Hyde::path(),
];
}
Expand Down Expand Up @@ -169,4 +170,15 @@ protected static function welcomeFrame(): string
</aside>
HTML;
}

protected function getPackageVersion(string $packageName): string
{
try {
$prettyVersion = InstalledVersions::getPrettyVersion($packageName);
} catch (OutOfBoundsException) {
//
}

return $prettyVersion ?? 'unreleased';
}
}
Loading