[2.x] Refactor features class to be a kernel singleton #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x-dev #1647 +/- ##
============================================
Coverage 99.97% 99.97%
+ Complexity 3550 1778 -1772
============================================
Files 368 184 -184
Lines 9582 4797 -4785
============================================
- Hits 9580 4796 -4784
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry. |
We need to do this later in the process, and not each time we create a kernel, as that is done way before the configuration is loaded. And a later construct adds less complexity than exposing a boot method on an initially empty features instance.
caendesilva
force-pushed
the
refactor-features-class-to-be-a-kernel-singleton
branch
from
e12a694 to
9365d12
Compare
This reverts commit 1f661e9.
This reverts commit a72546c5426a3dec3b0b7c4c6f91968986e81665.
caendesilva
force-pushed
the
refactor-features-class-to-be-a-kernel-singleton
branch
from
860bc66 to
dd04066
Compare
A config instance is required to construct the kernel
This reverts commit c29aa76.
For some reason assert same does still not work but that's fine
caendesilva
force-pushed
the
refactor-features-class-to-be-a-kernel-singleton
branch
from
01d0968 to
3ba4727
Compare
This was referenced Apr 8, 2024
caendesilva
force-pushed
the
refactor-features-class-to-be-a-kernel-singleton
branch
from
070d78c to
8dfb7f2
Compare
This was referenced Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.