Internal: Test code refactors and cleanup #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1960 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 1766 1766
===========================================
Files 182 182
Lines 4707 4707
===========================================
Hits 4707 4707 ☔ View full report in Codecov by Sentry. |
caendesilva
force-pushed
the
test-cleanup
branch
from
8a79666
to
2095b8c
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
9e81bff
to
c6787fa
Compare
This reverts commit fbc608e.
caendesilva
force-pushed
the
test-cleanup
branch
from
23376fd
to
0ae4a02
Compare
And way less confusing...
Saves about 100ms (down from 300ms)
Now runs in 30ms instead of almost 500ms...
caendesilva
force-pushed
the
test-cleanup
branch
from
f52e8b5
to
5c32057
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
c54212d
to
d1415d0
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
51932ad
to
13444a3
Compare
caendesilva
force-pushed
the
test-cleanup
branch
from
3e9eb7c
to
66f6a21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to refactoring to use helper methods for fluent and shared setup code for mocks, it uses more mocks, and updates the code to support this. It also refactors a bunch of unit tests to use mocks and the unit test case, the latter refactor can save about 200ms per testcase which is quite substantial. Combined this saves about two seconds for the entire unit test run (large improvement, starting at 5.5s to 3.5s)
Also adds some custom static analysis rules to improve the test code quality.