Rename config option hyde.enable_cache_busting to hyde.cache_busting
#1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option is best because it: 1. Maintains consistency with the rest of the configuration file. 2. Aligns with the explanatory comment. 3. Is clear and concise. It is part of the HydePHP v2 Asset API refactors #1904
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## normalize-the-asset-api #1980 +/- ##
===========================================================
Coverage 100.00% 100.00%
Complexity 1882 1882
===========================================================
Files 193 193
Lines 4974 4974
===========================================================
Hits 4974 4974 ☔ View full report in Codecov by Sentry. |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is best because it:
It is part of the HydePHP v2 Asset API refactors #1904