Remove default AppServiceProvider.php, fix #5 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in #4 via #5. See hydephp/framework#442.
The AppServiceProvider is not needed, and only handles changing the logo to a temporary one with the Ukrainian flag colours which can be handled in other places. The only benefit I see that it brings is that it gives a good point to configure application internals as it makes it clear that Hyde does in fact support service providers just the same a Laravel. Though I think this can easily be explained in documentation. And it does not fit in the 80% use case, and so I do not think it's worth having an entire directory that provides no real value to the majority of uses.
This PR removes the app directory containing the aforementioned provider, and the logo.txt. The only binding present is now inlined in the app.php config.