Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor publication service and add tests for it #694

Merged
merged 81 commits into from
Nov 25, 2022
Merged

Refactor publication service and add tests for it #694

merged 81 commits into from
Nov 25, 2022

Conversation

caendesilva
Copy link
Member

Refactors and simplifies the publication service class.

caendesilva and others added 30 commits November 25, 2022 20:19
@caendesilva
Inline and remove method PublicationService::formatNameForStorage
662d334
@caendesilva
Test getPublicationTypes helper
c596093
@caendesilva
Use Hyde::path helper instead of base_path for better compatibility
e9f2c35
@caendesilva
Cleanup code
0f2ab6e
@caendesilva
Extract method
bc1f5de
@caendesilva
Change helper to void
880a594
@caendesilva
Add more tests
6958b5d
@caendesilva
Cleanup code
cb3ea28
@caendesilva
Add assertion
6e3c1bd
@caendesilva
Split out assertion to new test method
cf6d028
@caendesilva
Split comma-separated values into multiple lines
289aa7e
@caendesilva
Use strong types for sorting callback
3d8ed2f
@caendesilva
Convert closure to arrow function
6af3175
@caendesilva
Union type int
f52431d
@caendesilva
Use the sortDirection schema option
c95dad9
@caendesilva
Test sorting
b71630d
@caendesilva
Extract method
5a2a8cf
@caendesilva
Remove collection sorting to reduce complexity
aad1197 
Plus no other collections use it and it's something that could just as well be used when it's actually needed.
@caendesilva
Rename method getPublicationData to parsePublicationFile
5a418de
@caendesilva
Replace qualifier with an import
cee9ba1
@caendesilva
Add parameter example
bf9a641
@caendesilva
Read file using absolute path
eecd88d
@caendesilva
Remove unused use statement
8946c47
@StyleCIBot
Apply fixes from StyleCI
74a7b74
@caendesilva
Remove redundant __slug magic front matter property
8b97f66
@caendesilva
Merge branch 'refactor-PublicationService' of github.com:hydephp/deve…
b6cd1c7 
…lop into refactor-PublicationService
@caendesilva
Pass along relative path
995193a
@caendesilva
Test publicationTypeExists method
928dbbb
@caendesilva
Simplify publicationTypeExists by inlining conditional
4d71e7d
@caendesilva
Remove redundant PHPDoc
f8fe0e1
caendesilva and others added 27 commits November 25, 2022 21:39
@caendesilva
Add parsing error tests
e47d5ea
@caendesilva
Add throws tag
8606ebe
@StyleCIBot
Apply fixes from StyleCI
9292078
@caendesilva
Finish PHPDoc with period for style
aa0fd5a
@caendesilva
Use absolute path when interacting with the filesystem
86087b9
@caendesilva
Remove premature file path qualifier
785ec78
@caendesilva
Remove premature file path qualifier
ee1d689
@caendesilva
Use relative paths for method arguments
aeced2b
@caendesilva
Import functions
6747c14
@caendesilva
Convert paths to relative within the glob helper
df81966
@caendesilva
Revert "Convert paths to relative within the glob helper"
086706c 
This reverts commit df81966.
@StyleCIBot
Apply fixes from StyleCI
cf31ef7
@caendesilva
Remove todo as it's handled by global media paths
2673ab0
@caendesilva
Add _media prefix within helper so it normalizes directory separators
7747ac1
@caendesilva
Test getMediaForPubType helper
67ae451
@caendesilva
Paths must be stored relatively internally
6c55b14
@caendesilva
Refactor foreach loops to use collection mappers
f74a9cb
@caendesilva
Refactor to pass data to path helper
1a088fc
@caendesilva
Convert string interpolation to concatenation and inline local variable
42fb16f
@caendesilva
Replace local variables with helper methods
b4bcfad
@StyleCIBot
Apply fixes from StyleCI
b4ae7a9
@caendesilva
Update PHPDoc to match simplified method
8cfb492
@caendesilva
Shorten helper method name
0b465a5
@caendesilva
Shift where ->getDirectory() is called
4f79e1b
@caendesilva
Convert concatenation to a scalar value
6a7befd
@caendesilva
Introduce parameter
5dc598e
@caendesilva
Replace self with static
6fbfbaf
@caendesilva caendesilva marked this pull request as ready for review November 25, 2022 21:28
@caendesilva caendesilva merged commit eaa2a95 into publications-feature Nov 25, 2022
@caendesilva caendesilva deleted the refactor-PublicationService branch November 25, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot