Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default values to the publication type class constructor #729

Merged
merged 13 commits into from
Dec 4, 2022
Merged

Add default values to the publication type class constructor #729

merged 13 commits into from
Dec 4, 2022

Conversation

caendesilva
Copy link
Member

Resolves the following:

I think the default values used in the make pubtype command can be set as default values in the constructor as it is extremely verbose, making it bulky to test.

Originally posted by @caendesilva in #685 (comment)

@caendesilva caendesilva mentioned this pull request Dec 4, 2022
Merged
29 tasks
@caendesilva caendesilva marked this pull request as ready for review December 4, 2022 12:42
@caendesilva caendesilva merged commit 42ce1d6 into publications-feature Dec 4, 2022
@caendesilva caendesilva deleted the add-default-values-to-publication-type-class branch December 4, 2022 12:42
@caendesilva caendesilva changed the title Add default values to the publication type class Add default values to the publication type class constructor Feb 9, 2023
@caendesilva caendesilva mentioned this pull request Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot