-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for and refactor publication field type validation rules #765
Add tests for and refactor publication field type validation rules #765
Conversation
This reverts commit 158d1f7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgasch Whenever you have time over, please take a look at my comments and questions.
packages/framework/src/Framework/Features/Publications/Models/PublicationFieldType.php
Outdated
Show resolved
Hide resolved
packages/framework/src/Framework/Features/Publications/Models/PublicationFieldType.php
Outdated
Show resolved
Hide resolved
packages/framework/src/Framework/Features/Publications/Models/PublicationFieldType.php
Outdated
Show resolved
Hide resolved
packages/framework/src/Framework/Features/Publications/Models/PublicationFieldType.php
Outdated
Show resolved
Hide resolved
…n-validation-rules
…n-validation-rules
…n-validation-rules
The range validations add a very large amount of complexity. I'm starting to think about how much we really need them. Sure length validation for article descriptions might be good, but do we really need to validate date ranges and integer values? Maybe it would be better to allow arbitrary Laravel validation rules to be specified in the schema file instead of its min/max values. |
No description provided.